Skip to content

refactor: use config crate for tap-agent #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2024
Merged

refactor: use config crate for tap-agent #410

merged 2 commits into from
Oct 25, 2024

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Oct 25, 2024

No description provided.

@gusinacio gusinacio force-pushed the gustavo/tap-256-use-config-crate-for-tap-agent branch from 3811eed to 1f3f248 Compare October 25, 2024 18:04
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11523182956

Details

  • 86 of 191 (45.03%) changed or added relevant lines in 12 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 73.002%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/src/config.rs 0 1 0.0%
tap-agent/src/main.rs 0 1 0.0%
tap-agent/src/database.rs 0 2 0.0%
config/src/grt.rs 0 5 0.0%
common/src/subgraph_client/client.rs 12 20 60.0%
tap-agent/src/agent/sender_allocation.rs 22 30 73.33%
tap-agent/src/config.rs 0 12 0.0%
tap-agent/src/agent/sender_account.rs 30 43 69.77%
tap-agent/src/agent.rs 0 55 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.21%
Totals Coverage Status
Change from base Build 11518141737: 0.3%
Covered Lines: 4997
Relevant Lines: 6845
💛 - Coveralls

@gusinacio gusinacio self-assigned this Oct 25, 2024
@gusinacio gusinacio requested a review from shiyasmohd October 25, 2024 18:18
suchapalaver
suchapalaver previously approved these changes Oct 25, 2024
View reviewed changes
@gusinacio gusinacio changed the title refactor: remove tap-agent config refactor: use config crate for tap-agent Oct 25, 2024
@gusinacio gusinacio merged commit 470bf5a into main Oct 25, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-256-use-config-crate-for-tap-agent branch October 25, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suchapalaver suchapalaver suchapalaver approved these changes

@shiyasmohd shiyasmohd Awaiting requested review from shiyasmohd

Assignees

@gusinacio gusinacio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gusinacio @suchapalaver